Skip to content
This repository has been archived by the owner on Jan 16, 2025. It is now read-only.

assimp 3.2 #49363

Closed
wants to merge 1 commit into from
Closed

assimp 3.2 #49363

wants to merge 1 commit into from

Conversation

yig
Copy link
Contributor

@yig yig commented Feb 19, 2016

All Submissions:

  • [yes] Have you followed the guidelines in our Contributing document?

New Formulae Submissions:

  • [yes] Does your submission pass
    brew audit --strict --online <formula> (where <formula> is the name of the formula you're submitting)?
  • [yes] Have you built your formula locally prior to submission with brew install <formula>?

Formulae Updates/Changes:

  • [n/a] If your changes include a new patch have you submitted the patch upstream & included a brief explanation/link to the upstream submission in the formula?

Changes to Homebrew's Core:

  • [n/a] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [n/a] Have you written new tests for your core changes, as applicable? Here's an example if you'd like one.
  • [yes] Have you successfully ran brew tests with your changes locally?

@@ -21,7 +20,9 @@ class Assimp < Formula
depends_on "boost" => [:recommended, :build]

def install
system "cmake", ".", *std_cmake_args
args = std_cmake_args
args << "-DASSIMP_BUILD_TESTS=OFF"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Building the tests downloads gtest, but the gtest repository has moved since this version (3.2) of assimp was released, so building the tests fails.
Building from HEAD doesn't have this problem. When the next assimp release happens, we can turn the tests back on and run the unit program that gets generated to test for success. (We wouldn't want to symlink it into /usr/local, though.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@bfontaine
Copy link
Contributor

Thank you for your contribution to Homebrew @yig; we appreciate it! 🎉

@bfontaine bfontaine closed this in 7db95ae Feb 21, 2016
@Homebrew Homebrew locked and limited conversation to collaborators Jul 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants