Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update.sh: add a shebang. #485

Closed
wants to merge 1 commit into from
Closed

update.sh: add a shebang. #485

wants to merge 1 commit into from

Conversation

MikeMcQuaid
Copy link
Member

@MikeMcQuaid MikeMcQuaid commented Jul 10, 2016

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

Makes it easier for e.g. shellcheck and friends to figure out the file type.

Makes it easier for e.g. shellcheck and friends to figure out the file
type.
@BrewTestBot BrewTestBot added the in progress Maintainers are working on this label Jul 10, 2016
@UniqMartin
Copy link
Contributor

The file extension is already a strong hint and many tools assume Bash anyway when confronted with the “Shell Script” file type. And it's easy enough to pass --shell=bash to shellcheck.

I'm not a big fan of this because this creates the impression that this is a standalone script (it isn't) and next thing someone will propose to add executable permissions. See also 27b606d and 6106ac9.

@MikeMcQuaid
Copy link
Member Author

Ok, fair enough. Need to work out how to coax my editor into doing that.

@MikeMcQuaid MikeMcQuaid deleted the update-shebang branch July 10, 2016 14:34
@BrewTestBot BrewTestBot removed the in progress Maintainers are working on this label Jul 10, 2016
@UniqMartin
Copy link
Contributor

Thanks! ❤️

@Homebrew Homebrew locked and limited conversation to collaborators May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants