Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compat: add missing method. #448

Closed
wants to merge 1 commit into from
Closed

compat: add missing method. #448

wants to merge 1 commit into from

Conversation

MikeMcQuaid
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

More work towards making Homebrew/brew a cross-platform core for e.g. Linuxbrew and Tigerbrew too.

@BrewTestBot BrewTestBot added the in progress Maintainers are working on this label Jul 4, 2016
UniqMartin
UniqMartin reviewed Jul 4, 2016
View reviewed changes
Library/Homebrew/compat/macos.rb

def has_apple_developer_tools?
DevelopmentTools.installed?
end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not actually missing at this point. Looks like this should have been part of #455 instead.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, will merge this PR after that 👍

@UniqMartin UniqMartin mentioned this pull request Jul 5, 2016
Merged
5 tasks
@MikeMcQuaid
Copy link
Member Author

Merged into #455.

@MikeMcQuaid MikeMcQuaid closed this Jul 6, 2016
@MikeMcQuaid MikeMcQuaid deleted the compat-add-missing-method branch July 6, 2016 09:58
@BrewTestBot BrewTestBot removed the in progress Maintainers are working on this label Jul 6, 2016
iMichka pushed a commit to iMichka/brew that referenced this pull request Sep 11, 2017
@sjackman
README.md: Add Donate (Homebrew#448)
85f0cba
@Homebrew Homebrew locked and limited conversation to collaborators May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MikeMcQuaid @UniqMartin @BrewTestBot