Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add functionality to also search on content #59

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from
Open

Add functionality to also search on content #59

wants to merge 1 commit into from

Conversation

kenjihikmatullah
Copy link

Background
Currently we can only search based on note title

Changes
Enable to also search on note content alongside title

Notes:
If this idea is valuable and approved, perhaps we need to also rename the placeholder and corresponding attribute name from searchedTitleText to something like searchKeywordText

HellBus1
HellBus1 approved these changes Dec 4, 2024
View reviewed changes
Copy link
Owner

@HellBus1 HellBus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea! The search should be more flexible than just by title

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HellBus1 HellBus1 HellBus1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjihikmatullah @HellBus1