chore(frontend/lint): Fix lint issues

Grohden · Aug 5, 2020 · 4b7cfc6 · 4b7cfc6
1 parent 0194579
commit 4b7cfc6
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 62 deletions.
diff --git a/frontend/lib/ui/pages/home/home_page.dart b/frontend/lib/ui/pages/home/home_page.dart
@@ -1,7 +1,7 @@
 import 'package:flutter/material.dart';
 import 'package:get/get.dart';
 
-import '../../templates/two_slot_container.dart';
+import '../../templates/three_slot_container.dart';
 import '../starred/starred_page.dart';
 import '../tags/tags_page.dart';
 import 'widgets/sidebar.dart';

diff --git a/frontend/lib/ui/pages/repository_details/repository_details_page.dart b/frontend/lib/ui/pages/repository_details/repository_details_page.dart
@@ -4,12 +4,12 @@ import 'dart:html';
 import 'package:dio/dio.dart';
 import 'package:flutter/material.dart';
 import 'package:get/get.dart';
-import 'package:repo_tagger/ui/utils/browser.dart';
 
 import '../../../api/tagger/repository_tagger_client.dart';
 import '../../../router.dart';
 import '../../molecules/detail_chip.dart';
 import '../../molecules/load_page_error.dart';
+import '../../utils/browser.dart';
 import 'widgets/readme_container.dart';
 import 'widgets/tags_container.dart';
 

diff --git a/frontend/lib/ui/pages/splash/splash_page.dart b/frontend/lib/ui/pages/splash/splash_page.dart
@@ -2,8 +2,8 @@ import 'dart:async';
 
 import 'package:flutter/material.dart';
 import 'package:get/get.dart';
-import 'package:repo_tagger/api/tagger/repository_tagger_client.dart';
 
+import '../../../api/tagger/repository_tagger_client.dart';
 import '../../../router.dart';
 
 /// Initial page that redirects the user

diff --git a/frontend/lib/ui/pages/starred/starred_page.dart b/frontend/lib/ui/pages/starred/starred_page.dart
@@ -1,13 +1,11 @@
 import 'package:flutter/material.dart';
 import 'package:get/get.dart';
-import 'package:repo_tagger/ui/templates/repository_list.dart';
 
 import '../../../api/tagger/repository_tagger_client.dart';
 import '../../../router.dart';
-import '../../molecules/detail_chip.dart';
 import '../../molecules/load_page_error.dart';
 import '../../molecules/page_title.dart';
-import '../../templates/page_body.dart';
+import '../../templates/repository_list.dart';
 
 part 'starred_bindings.dart';
 

diff --git a/frontend/lib/ui/pages/tag_repositories/tag_repositories_page.dart b/frontend/lib/ui/pages/tag_repositories/tag_repositories_page.dart
@@ -1,12 +1,11 @@
 import 'package:flutter/material.dart';
 import 'package:get/get.dart';
-import 'package:repo_tagger/ui/templates/repository_list.dart';
 
 import '../../../api/tagger/repository_tagger_client.dart';
 import '../../../router.dart';
 import '../../molecules/load_page_error.dart';
 import '../../molecules/page_title.dart';
-import '../../templates/page_body.dart';
+import '../../templates/repository_list.dart';
 
 part 'tag_repositories_bindings.dart';
 
@@ -40,52 +39,4 @@ class TagRepositoriesPage extends GetView<TagRepositoriesController> {
       items: controller.repositories.value,
     );
   }
-
-  Widget _buildList(List<SimpleRepository> items, TextTheme style) {
-    return ListView.separated(
-        itemCount: items.length,
-        padding: const EdgeInsets.all(kStandardPadding),
-        separatorBuilder: (_, __) => const Divider(thickness: 1),
-        itemBuilder: (context, index) {
-          final item = items[index];
-
-          return ListTile(
-            onTap: () => controller.openRepo(item),
-            title: Text(item.name, style: style.headline6),
-            subtitle: Column(
-              crossAxisAlignment: CrossAxisAlignment.start,
-              children: [
-                if (item.description?.isNotEmpty == true)
-                  Text(item.description ?? ''),
-                _buildChipDetails(item),
-              ],
-            ),
-          );
-        });
-  }
-
-  Widget _buildChipDetails(SimpleRepository item) {
-    const spacing = SizedBox(width: 4);
-
-    return Row(
-      children: [
-        if (item.language?.isNotEmpty == true)
-          Chip(
-            visualDensity: VisualDensity.compact,
-            label: Text(item.language.toString()),
-          ),
-        spacing,
-        Chip(
-          visualDensity: VisualDensity.compact,
-          label: Row(
-            children: [
-              const Icon(Icons.star_border, size: 14),
-              spacing,
-              Text(item.stargazersCount.toString()),
-            ],
-          ),
-        ),
-      ],
-    );
-  }
 }
diff --git a/.../lib/ui/templates/two_slot_container.dart → ...ib/ui/templates/three_slot_container.dart b/.../lib/ui/templates/two_slot_container.dart → ...ib/ui/templates/three_slot_container.dart
@@ -20,17 +20,13 @@ class ThreeSlotContainer extends StatelessWidget {
 
   @override
   Widget build(BuildContext context) {
-    final theme = Theme.of(context);
-
     return Row(
       mainAxisSize: MainAxisSize.max,
       crossAxisAlignment: CrossAxisAlignment.start,
       children: [
-        if (leftSlot != null)
-          SizedBox(width: leftWidth, child: leftSlot),
+        if (leftSlot != null) SizedBox(width: leftWidth, child: leftSlot),
         Expanded(child: centralSlot),
-        if (rightSlot != null)
-          SizedBox(width: rightWidth, child: rightSlot)
+        if (rightSlot != null) SizedBox(width: rightWidth, child: rightSlot)
       ],
     );
   }