Add the ability to set synchronous timeout.

[nat-henderson]

This is useful for old operations like DNS, which are synchronous but also long-running.
This fixes hashicorp/terraform-provider-google#5008.

Release Note Template for Downstream PRs (will be copied)

`all`: Added `synchronous_timeout` to provider block to allow setting higher per-operation-poll timeouts.

[modular-magician]

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, f3d0ce2.

Pull request statuses

No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1449
depends: GoogleCloudPlatform/terraform-google-conversion#274
depends: hashicorp/terraform-provider-google#5013

[chrisst]

I have mild feelings about naming.

Also you should also be updating relevant docs, I think primarily https://www.terraform.io/docs/providers/google/guides/provider_reference.html .

Overall I think it's ok, but there are sharp edges that we should definitely document in a public facing location. EG: many requests are killed by googleapis server side at 30s, so a customer may bump this timeout and end up just seeing a different error message.

If the linked issue suffers from the server side timeout then this is not worth adding until we see an example API that would benefit from it.

[chrisst]

I would lean towards "RequestTimeout" or "HTTPTimeout" as this is going to affect every request that Terraform makes to the API including polling of async resources.

[modular-magician]

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 8410a9f.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

[modular-magician]

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, b6417b0.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

[nat-henderson]

Lots of passing integration tests - not going to wait for the full suite a second time, results are looking good.