Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nil check to dns set func #2618

Merged
merged 2 commits into from
Nov 9, 2019

Conversation

danawillow
Copy link
Contributor

Fixes hashicorp/terraform-provider-google#4805

Release Note Template for Downstream PRs (will be copied)

`dns`: fixed crash when `network` blocks are defined without `network_url`s

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 2735cdd.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1345
depends: hashicorp/terraform-provider-google#4840

danawillow and others added 2 commits November 9, 2019 00:40
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit 7de9a59 into GoogleCloudPlatform:master Nov 9, 2019
@danawillow danawillow deleted the tf-4805 branch November 9, 2019 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resource_dns_managed_zone seems to make terraform crash
4 participants