Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting 'location' in google_sql_database_instance backup_configuration #2498

Merged
merged 2 commits into from
Oct 21, 2019

Conversation

danawillow
Copy link
Contributor

Upstreams hashicorp/terraform-provider-google#4681

Release Note Template for Downstream PRs (will be copied)

`sql`: added `location` field to `backup_configuration` block in `google_sql_database_instance`

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 39c83f0.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1282
depends: hashicorp/terraform-provider-google#4722

JamesGuthrie and others added 2 commits October 21, 2019 22:17
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit 2e6058d into GoogleCloudPlatform:master Oct 21, 2019
@danawillow danawillow deleted the tf-4681 branch October 21, 2019 22:19
JanMa pushed a commit to JanMa/magic-modules that referenced this pull request Oct 25, 2019
JanMa added a commit to JanMa/magic-modules that referenced this pull request Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants