Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only validate cidr block when the cidr block value is known #2394

Conversation

rileykarson
Copy link
Member

Fixes hashicorp/terraform-provider-google#4186

Also please fact-check me on my comment in the issue, I think it's correct.

Release Note Template for Downstream PRs (will be copied)

`container`: fixed an overly-aggressive validation for `master_ipv4_cidr_block` in `google_container_cluster`

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, b77f635.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in Ansible.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1211
depends: hashicorp/terraform-provider-google#4577
depends: modular-magician/inspec-gcp#212

rileykarson and others added 2 commits October 1, 2019 22:19
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician force-pushed the container-known-validation branch from b77f635 to 3b80ff4 Compare October 1, 2019 22:19
@modular-magician modular-magician merged commit 0727121 into GoogleCloudPlatform:master Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

master_ipv4_cidr_block must be set if enable_private_nodes
4 participants