Adding next_hop_ilb attribute to compute route resource #2215

Madankapoor · 2019-08-20T20:33:18Z

This adds the beta feature to the route resource for next-hop internal load balancer. https://cloud.google.com/compute/docs/reference/rest/beta/routes/insert

Release Note for Downstream PRs (will be copied)

compute: The compute routes includes next_hop_ilb attribute support in beta.

modular-magician · 2019-08-20T20:36:35Z

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. They will authorize it to run through our CI pipeline, which will generate downstream PRs.

Thanks for your contribution! A human will be with you soon.

@rambleraptor, please review this PR or find an appropriate assignee.

rambleraptor · 2019-08-20T21:28:50Z

Hello! I'm going to kick off our CI and put @rileykarson on this (since it's a Terraform-only contribution)

modular-magician · 2019-08-20T21:41:50Z

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 7072493.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1076

rileykarson · 2019-08-20T21:48:42Z

Hey @Madankapoor!

Do you mind adding an example using this field? If you add an example definition based on the Example type, MM will automatically generate a test based on the example's config.

Madankapoor · 2019-08-21T13:35:31Z

Hi @rileykarson, Thank you for your feedback. I have added a test case as required.

modular-magician · 2019-08-21T16:14:24Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 52e684d.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google#4311

rileykarson · 2019-08-21T17:28:00Z

Thanks @Madankapoor! I'm passing review off to @slevenick because they have more background on the feature than me.

slevenick

Looks good, thanks! Just needs a simple change and then I'll take care of merging in the downstreams.

products/compute/terraform.yaml

slevenick · 2019-08-21T22:18:39Z

templates/terraform/examples/route_ilb_beta.tf.erb

+  subnetwork            = "${google_compute_subnetwork.default.name}"
+}
+
+resource "google_compute_route" "default" {


primary_resource_id is supposed to be used within the example template to allow terraform to access the resource's id for import test purposes. It doesn't get used in beta-only examples, but can you change it so that when this moves to the google provider it will work?

Example: https://github.com/GoogleCloudPlatform/magic-modules/blob/master/templates/terraform/examples/node_template_server_binding.tf.erb

ya i have added primary id

Can you replace "google_compute_route" "default" with "google_compute_route" "<%= ctx[:primary_resource_id] %>" here

It allows us to access the name of the terraform resource for import later. This is different than the name field on the resource itself, as we need to know the name used to identify the block for testing import

Madankapoor · 2019-08-22T17:32:53Z

@slevenick I have made requested changes and responded back to the questions. Does it seem good ?

modular-magician · 2019-08-23T17:57:22Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 18bec7d.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: modular-magician/inspec-gcp#190

slevenick

Just a couple small things, but once they are fixed I will merge!

slevenick · 2019-08-23T18:07:27Z

templates/terraform/examples/route_ilb_beta.tf.erb

@@ -0,0 +1,52 @@
+resource "google_compute_network" "default" {
+  provider      = "google-beta"


Can you fix the spacing on this block? Seems to have gotten mixed up

ya fixed it.

slevenick · 2019-08-23T18:09:24Z

templates/terraform/examples/route_ilb_beta.tf.erb

+  subnetwork            = "${google_compute_subnetwork.default.name}"
+}
+
+resource "google_compute_route" "default" {


Can you replace "google_compute_route" "default" with "google_compute_route" "<%= ctx[:primary_resource_id] %>" here

It allows us to access the name of the terraform resource for import later. This is different than the name field on the resource itself, as we need to know the name used to identify the block for testing import

modular-magician · 2019-08-26T16:45:21Z

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 000eeea.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
terraform-provider-google already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

slevenick

Thanks for the addition!

googlebot added the cla: yes label Aug 20, 2019

modular-magician added the community label Aug 20, 2019

rambleraptor requested a review from rileykarson August 20, 2019 21:28

modular-magician added downstream-generated terraform-provider-google-beta labels Aug 20, 2019

modular-magician added the terraform-provider-google label Aug 21, 2019

rileykarson requested review from slevenick and removed request for rileykarson August 21, 2019 17:28

slevenick requested changes Aug 21, 2019

View reviewed changes

modular-magician added the inspec label Aug 23, 2019

slevenick requested changes Aug 23, 2019

View reviewed changes

slevenick approved these changes Aug 26, 2019

View reviewed changes

modular-magician added the automerged label Aug 26, 2019

Madankapoor added 7 commits August 26, 2019 17:49

Adding next ILB beta route

be4ee20

Adding Test Cases

c487d64

Adding Test Cases

f25cf6a

Adding testcase

2acc7d8

Fixing Test Case

4b3d222

Adding primary resource id

ef14a9d

Adding route name for import

ad8eda3

Fix spacing

dda9f71

modular-magician merged commit d481725 into GoogleCloudPlatform:master Aug 26, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding next_hop_ilb attribute to compute route resource #2215

Adding next_hop_ilb attribute to compute route resource #2215

Madankapoor commented Aug 20, 2019

modular-magician commented Aug 20, 2019

rambleraptor commented Aug 20, 2019

modular-magician commented Aug 20, 2019

rileykarson commented Aug 20, 2019

Madankapoor commented Aug 21, 2019

modular-magician commented Aug 21, 2019

rileykarson commented Aug 21, 2019

slevenick left a comment

slevenick Aug 21, 2019

Madankapoor Aug 22, 2019

slevenick Aug 23, 2019

Madankapoor commented Aug 22, 2019

modular-magician commented Aug 23, 2019

slevenick left a comment

slevenick Aug 23, 2019

Madankapoor Aug 23, 2019

slevenick Aug 23, 2019

modular-magician commented Aug 26, 2019

slevenick left a comment

		@@ -0,0 +1,52 @@
		resource "google_compute_network" "default" {
		provider = "google-beta"

Adding next_hop_ilb attribute to compute route resource #2215

Adding next_hop_ilb attribute to compute route resource #2215

Conversation

Madankapoor commented Aug 20, 2019

Release Note for Downstream PRs (will be copied)

modular-magician commented Aug 20, 2019

rambleraptor commented Aug 20, 2019

modular-magician commented Aug 20, 2019

Pull request statuses

New Pull Requests

rileykarson commented Aug 20, 2019

Madankapoor commented Aug 21, 2019

modular-magician commented Aug 21, 2019

Pull request statuses

New Pull Requests

rileykarson commented Aug 21, 2019

slevenick left a comment

Choose a reason for hiding this comment

slevenick Aug 21, 2019

Choose a reason for hiding this comment

Madankapoor Aug 22, 2019

Choose a reason for hiding this comment

slevenick Aug 23, 2019

Choose a reason for hiding this comment

Madankapoor commented Aug 22, 2019

modular-magician commented Aug 23, 2019

Pull request statuses

New Pull Requests

slevenick left a comment

Choose a reason for hiding this comment

slevenick Aug 23, 2019

Choose a reason for hiding this comment

Madankapoor Aug 23, 2019

Choose a reason for hiding this comment

slevenick Aug 23, 2019

Choose a reason for hiding this comment

modular-magician commented Aug 26, 2019

Pull request statuses

New Pull Requests

slevenick left a comment

Choose a reason for hiding this comment