Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RegionHealthCheck to compute #2195

Merged
merged 5 commits into from
Sep 17, 2019
Merged

Add RegionHealthCheck to compute #2195

merged 5 commits into from
Sep 17, 2019

Conversation

tysen
Copy link

@tysen tysen commented Aug 15, 2019

Second of many PRs necessary to support level 7 HTTP(S) load balancing.
Also updates HealthCheck to include HTTP2HealthCheck

Release Note for Downstream PRs (will be copied)

`google_compute_region_health_check` is now available. This and `google_compute_health_check` now include additional support for HTTP2 health checks.

@tysen tysen requested a review from danawillow August 15, 2019 22:38
@modular-magician
Copy link
Collaborator

modular-magician commented Aug 15, 2019 •
edited by rambleraptor
Loading

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 3d16d7d5b9d3ddd65540aa051b0cb2349d6cf051.

Pull request statuses

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#1058
depends: GoogleCloudPlatform/terraform-google-conversion#168
depends: hashicorp/terraform-provider-google#4270
depends: modular-magician/inspec-gcp#185

danawillow
danawillow suggested changes Aug 21, 2019
View reviewed changes
products/compute/api.yaml Show resolved Hide resolved
products/compute/api.yaml Outdated Show resolved Hide resolved
products/compute/api.yaml Outdated Show resolved Hide resolved
third_party/terraform/tests/resource_compute_health_check_test.go Outdated Show resolved Hide resolved
third_party/terraform/tests/resource_compute_region_health_check_test.go.erb
@@ -0,0 +1,596 @@
<% autogen_exception -%>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of adding a whole bunch of new handwritten tests, would it be possible to make some or all of these generated?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a bunch of examples and removed the duplicating tests in the handwritten files. I left the tests that appeared to be special cases.

third_party/terraform/tests/resource_compute_region_health_check_test.go.erb Outdated Show resolved Hide resolved
@tysen tysen requested a review from danawillow August 28, 2019 23:51
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 0acca38.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

danawillow
danawillow suggested changes Sep 4, 2019
View reviewed changes
Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it also be possible to add tests that cover the fields in each of the individual health check blocks right now they all cover port and some have others, but I think we're missing a few of them.

products/compute/api.yaml Outdated Show resolved Hide resolved
products/compute/api.yaml Outdated Show resolved Hide resolved
@tysen tysen requested a review from danawillow September 5, 2019 22:28
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 7393dff.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
Ansible already has an open PR.
InSpec already has an open PR.

New Pull Requests

I didn't open any new pull requests because of this PR.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, a4b287f.

Pull request statuses

terraform-provider-google-beta already has an open PR.
terraform-google-conversion already has an open PR.
terraform-provider-google already has an open PR.
InSpec already has an open PR.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: ansible-collections/google.cloud#5

@rambleraptor
Copy link
Contributor

Ansible stuff looks fine to me!

Ty Larrabee and others added 5 commits September 17, 2019 17:18
@modular-magician modular-magician merged commit 495206c into GoogleCloudPlatform:master Sep 17, 2019
This was referenced Oct 2, 2019
Merged
Merged
@danawillow danawillow mentioned this pull request Mar 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danawillow danawillow danawillow approved these changes

Assignees
No one assigned
Labels
ansible automerged cla: yes downstream-generated inspec terraform-google-conversion terraform-provider-google terraform-provider-google-beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tysen @modular-magician @rambleraptor @danawillow @googlebot