Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting notification channel enabled to false #1935

Merged
merged 3 commits into from
Jun 18, 2019

Conversation

danawillow
Copy link
Contributor

Fixes hashicorp/terraform-provider-google#3869

Also puts monitoring in the GA section since it's part of TPG.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of b6555ba.

Pull request statuses

No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#864
depends: GoogleCloudPlatform/terraform-google-conversion#111
depends: hashicorp/terraform-provider-google#3874

Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit c1f7835 into GoogleCloudPlatform:master Jun 18, 2019
@danawillow danawillow deleted the tf-3869 branch June 18, 2019 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

monitoring_notification_channel enabled property does not work.
4 participants