Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terraform: Skip diffs when managed certs are specified with absolute FQDNs #1624

Merged
merged 3 commits into from
Apr 29, 2019
Merged

Terraform: Skip diffs when managed certs are specified with absolute FQDNs #1624

merged 3 commits into from
Apr 29, 2019

Conversation

drebes
Copy link
Member

@drebes drebes commented Apr 5, 2019

[all]

[terraform]

[terraform-beta]

Skip diffs when managed certs are specified with absolute FQDNs.

[ansible]

[inspec]

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. They will authorize it to run through our CI pipeline, which will generate downstream PRs.

Thanks for your contribution! A human will be with you soon.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
This PR seems not to have generated downstream PRs before, as of 34329a1c1670cbccb8f9427f08f428d45e8787d7.

Pull request statuses

No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: hashicorp/terraform-provider-google-beta#591

@drebes drebes force-pushed the terraform-fix-managed-ssl-fqdn branch 2 times, most recently from 587ebf2 to 22a4e64 Compare April 5, 2019 20:45
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 22a4e64.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I built this PR into one or more new PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: GoogleCloudPlatform/terraform-google-conversion#53
depends: hashicorp/terraform-provider-google#3392

@drebes drebes force-pushed the terraform-fix-managed-ssl-fqdn branch from 22a4e64 to efafcd9 Compare April 6, 2019 07:33
@rileykarson
Copy link
Member

Do you mind updating https://github.com/GoogleCloudPlatform/magic-modules/blob/master/provider/terraform_object_library.rb#L92 to be in the compiled files list and point to the new filename?

@drebes drebes force-pushed the terraform-fix-managed-ssl-fqdn branch from efafcd9 to d9d8974 Compare April 9, 2019 06:33
@drebes
Copy link
Member Author

drebes commented Apr 10, 2019

Done.

@drebes drebes force-pushed the terraform-fix-managed-ssl-fqdn branch from d9d8974 to c0dc3f7 Compare April 25, 2019 02:41
@drebes
Copy link
Member Author

drebes commented Apr 25, 2019

Please let me know if there's anything left to change.

rileykarson
rileykarson reviewed Apr 25, 2019
View reviewed changes
Copy link
Member

@rileykarson rileykarson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry! I fell behind on reviews a little and managed to lose track of this PR. Just one little change left, we need to change the input file, and not the output one from .go to .go.erb in the mapper.

provider/terraform_object_library.rb Outdated Show resolved Hide resolved
provider/terraform_object_library.rb Outdated Show resolved Hide resolved
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@drebes drebes force-pushed the terraform-fix-managed-ssl-fqdn branch 3 times, most recently from 2e62e7e to d351718 Compare April 25, 2019 23:34
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@drebes drebes force-pushed the terraform-fix-managed-ssl-fqdn branch from d351718 to 5d49073 Compare April 27, 2019 15:17
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 5d49073.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 5397bfa.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician, I work on Magic Modules.
I see that this PR has already had some downstream PRs generated. Any open downstreams are already updated to your most recent commit, 5397bfa.

Pull request statuses

terraform-provider-google-beta already has an open PR.
No diff detected in terraform-google-conversion.
No diff detected in terraform-provider-google.
No diff detected in Ansible.
No diff detected in Inspec.

New Pull Requests

I didn't open any new pull requests because of this PR.

drebes and others added 3 commits April 29, 2019 19:16
@drebes @modular-magician
Terraform: Fix issue with FQDN SSL Managed certs causing a diff
e2ea38e
@rileykarson @modular-magician
Fix spacing
1104cc5
@modular-magician
Update tracked submodules -> HEAD on Mon Apr 29 19:16:56 UTC 2019
e9ff36f 
Tracked submodules are build/terraform-beta build/terraform-mapper build/terraform build/ansible build/inspec.
@modular-magician modular-magician force-pushed the terraform-fix-managed-ssl-fqdn branch from 5397bfa to e9ff36f Compare April 29, 2019 19:17
@modular-magician modular-magician merged commit 9b68d1e into GoogleCloudPlatform:master Apr 29, 2019
@drebes drebes deleted the terraform-fix-managed-ssl-fqdn branch March 13, 2020 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rileykarson rileykarson rileykarson approved these changes

Assignees
No one assigned
Labels
automerged cla: yes community downstream-generated terraform-google-conversion terraform-provider-google terraform-provider-google-beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@drebes @modular-magician @rileykarson @googlebot