Skip to content

The authorize form should be used only if authorize option true. #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 5, 2018

Conversation

makasim
Copy link
Member

@makasim makasim commented Apr 3, 2018

No description provided.

@dkarlovi dkarlovi added the Bug label Apr 4, 2018
@dkarlovi
Copy link
Contributor

dkarlovi commented Apr 4, 2018

Why haven't our tests caught this?

@makasim
Copy link
Member Author

makasim commented Apr 4, 2018

I am build app on top of Symfony Flex, there is no forms and templating in my setup, things breaks here and there (:

@makasim
Copy link
Member Author

makasim commented Apr 4, 2018

Added tests

@dkarlovi please review

@dkarlovi
Copy link
Contributor

dkarlovi commented Apr 5, 2018

This was previously done in #466, but since you've added tests, we should merge this one instead.

@dkarlovi dkarlovi merged commit 2b76d49 into FriendsOfSymfony:1.6 Apr 5, 2018
@makasim makasim deleted the decouple-from-form branch April 5, 2018 05:51
@nhepner1
Copy link

It might be helpful to note that authorize needs to be set explicitly to false in order to trigger the bypass. Apparently other config settings are added for basically any other definition.

fos_oauth_server:
  # ... other settings... 
  authorize: false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants