Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds table transforms #45
adds table transforms #45
Changes from 6 commits
2fa8f76
c1767c5
2e0b87c
7a57684
3f8db5b
bfaec10
90c3bae
eef71ec
cd42f1d
38f35a0
a033d1d
5a40475
0de742b
128cf97
be5dbff
e90dc4b
1a22791
a03bc72
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does
collect(item.data)
not work?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be able to use that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for
skipmissing
here, right?x[idx]
is a value andtfm.catdict[col]
is a vector of categorical values (which doesn't containmissing
).findfirst
is just assigning an index based on which symbol intfm.catdict[col]
matchesx[idx]
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initially I was thinking if someone creates
catdict
usingunique
or something, and if somehowmissing
is a part of this vector then an error could be thrown, but yeah it might just be better to remove it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably better to
map(v -> filter!(!ismissing, v), values(catdict))
when constructing the transform. We could throw a warning when that happens too.