Add release builds for darwin/amd64 and darwin/arm64 #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The approach of cross-compiling for each platform on Linux was difficult for cases like LBM that required native compilation of C/C++. For this reason, I use compilers suitable for each OS to perform release builds. Along with this, the docker image for cross-compiling run from `make reproducible` and the shell script used for it are no longer required.
|
This PR has been integrated into #130. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NOTE: This PR will be in progress after #130 is merged.
With this PR, two release builds for Intel and ARM MacOS have been added.
It's easy to cross-compile in Golang to target different OS, but our LBM contains some native compilation steps for the build. For the previous PR, we tried to use a docker container to cross-compile. It is, however, difficult to build binaries for MacOS on Linux, and the best way to build binaries for MacOS is to use Xcode on MacOS. So I switched to using the
macosimage on github actions instead of cross-building on a docker container. For this reason, the docker image andmake reproduciblefor cross-compilation have been removed and they have been replaced by a simplemake buildinrelease-build.yml.The current
lbmv0.46.0 binaries depend on thelibwasmvmv1.0.0-0.10.0 library. To run these release binaries, it needs to obtain the corresponding dynamic libraries in the table below from line/wasmvm.linux/amd64libwasmvm.x86_64.solinux/arm64libwasmvm.aarch64.sodarwin/*libwasmvm.dylibMotivation and context
See Issue #116
How has this been tested?
linux/amd64: On Docker container using theamd64/ubuntu:latestimage on a M1 macbook.linux/arm64: On Docker container using theubuntu:latestimage on M1 macbook.darwin/amd64: On M1 macbook (with Rosetta 2).darwin/arm64: On M1 macbook.Screenshots (if appropriate):
Checklist: