Apply suggestions from code review

Ferrite-FEM · Feb 26, 2025 · 5f0b0f8 · 5f0b0f8
1 parent 87c4fc7
commit 5f0b0f8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/Dofs/DofHandler.jl b/src/Dofs/DofHandler.jl
@@ -933,8 +933,8 @@ function evaluate_at_grid_nodes(dh::DofHandler, u::AbstractVector, fieldname::Sy
     return _evaluate_at_grid_nodes(dh, u, fieldname)
 end
 
-_function_value_type(::ScalarInterpolation, ::AbstractVector{T}) where {T} = T
-_function_value_type(::VectorInterpolation{vdim}, ::AbstractVector{T}) where {vdim, T <: Number} = Vec{vdim, T}
+function_value_init(::ScalarInterpolation, ::AbstractVector{T}) where {T} = zero(T)
+function_value_init(::VectorInterpolation{vdim}, ::AbstractVector{T}) where {vdim, T <: Number} = zero(Vec{vdim, T})
 
 # Internal method that have the vtk option to allocate the output differently
 function _evaluate_at_grid_nodes(dh::DofHandler{sdim}, u::AbstractVector{T}, fieldname::Symbol, ::Val{vtk} = Val(false)) where {T, vtk, sdim}
@@ -943,7 +943,7 @@ function _evaluate_at_grid_nodes(dh::DofHandler{sdim}, u::AbstractVector{T}, fie
     # Figure out the return type (scalar or vector)
     field_idx = find_field(dh, fieldname)
     ip = getfieldinterpolation(dh, field_idx)
-    RT = _function_value_type(ip, u)
+    RT = typeof(function_value_init(ip, u))
     if vtk
         # VTK output of solution field (or L2 projected scalar data)
         n_c = n_components(ip)

diff --git a/test/test_interpolations.jl b/test/test_interpolations.jl
@@ -52,7 +52,7 @@ function test_interpolation_properties(ip::Interpolation{RefShape, FunOrder}) wh
         # Test A-D
         _test_interpolation_properties(dof_data, refshape_data)
 
-        # Test E: All base functions implemented and infers correct types
+        # Test E: All base functions implemented and infers correct types.
         # Argument errors for 0th and n+1 indices.
         for T in (Float64, Float32)
             ξ = zero(Vec{Ferrite.getrefdim(ip), T})