Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] add "coming soon" page to Expensify Help site #9869

Merged
merged 5 commits into from
Jul 13, 2022

Conversation

marcochavezf
Copy link
Contributor

@marcochavezf marcochavezf commented Jul 12, 2022

HOLD ON #9765

cc @roryabraham @michelle-thompson

Details

This PR replaces the main page with a "coming soon" page. We're going to replace it again with the main page once we upload more content to the Expensify Help site.

Also this PR is branched off from #9765. Once #9765 is merged I'm going to merge main into this branch and the real number of commits will be displayed.

Fixed Issues

$ #9830

Tests

  1. (you need ruby and bundler installed to do this, more info here)

  2. Run:

    cd docs
    bundle install
    bundle exec jekyll serve
  3. Make sure the "coming soon" page is displayed in the root directory (index.html).

  4. Verify you can access the main site by visiting http://localhost:4000/main (atm the content area of the main page is empty, it just displays the LHN).

Screenshots

Web

localhost_4000_

Mobile Web

@marcochavezf marcochavezf requested a review from a team as a code owner July 12, 2022 23:39
@marcochavezf marcochavezf self-assigned this Jul 12, 2022
@melvin-bot melvin-bot bot requested review from ctkochan22 and removed request for a team July 12, 2022 23:39
@marcochavezf marcochavezf changed the title [HOLD] add "coming soon" page to Expensify Help site [HOLD][No QA] add "coming soon" page to Expensify Help site Jul 12, 2022
@ctkochan22
Copy link
Contributor

I think you'll need to merge main a lot of changes are done here already https://github.com/Expensify/App/pull/9765/files

@marcochavezf marcochavezf changed the title [HOLD][No QA] add "coming soon" page to Expensify Help site [No QA] add "coming soon" page to Expensify Help site Jul 13, 2022
@marcochavezf
Copy link
Contributor Author

I think you'll need to merge main a lot of changes are done here already https://github.com/Expensify/App/pull/9765/files

yup, merged main, PR ready to be reviewed

@ctkochan22 ctkochan22 merged commit 684f2c3 into main Jul 13, 2022
@ctkochan22 ctkochan22 deleted the marco-comingSoonPage branch July 13, 2022 16:26
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @chiragsalian in version: 1.1.84-13 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants