fix(accordion, accordion-item, action, action-bar, action-group, action-menu, icon, list-item, popover): update components and e2e tests #8993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing tokens after finding inconsistensies when writing the e2e test
alisonailea
added
the
pr ready for visual snapshots
alisonailea
added
pr ready for visual snapshots
alisonailea
added
pr ready for visual snapshots
driskull
reviewed
Mar 25, 2024
driskull
reviewed
Mar 25, 2024
we can’t test ::after so we need a new div :shrug-emoji:
alisonailea
changed the title
these tokens are unused as the action-group in the shadow dom does not use popover or have it’s own border and all other elements in the action bar are slotted and so should have their own styles.
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
bot
added
the
Stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7180
Summary
To be merged after #9027
Updates components to fix unit tests, remove extraneous tokens, and clean up styles.
This is alternative approach to the fixes proposed in #8991