Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] [two state button] loader background color inconsistent when checked #921

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

rkondra-eightfold
Copy link
Contributor

SUMMARY:

  • When checked prop is true for 2 state button , the loader background is default and not button background

GITHUB ISSUE (Open Source Contributors)

JIRA TASK (Eightfold Employees Only):

https://eightfoldai.atlassian.net/browse/ENG-121243

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist (storybook tests)
  • I have added unittests for this change

TEST PLAN:

  • Visit storybook for TwoStateButton
  • Toggle loading to True
  • toggle checked to True, before vs after
Screenshot 2024-12-12 at 9 19 50 AM Screenshot 2024-12-12 at 9 10 10 AM
  • Regression test: checked false, loading true, etc ...
Screenshot 2024-12-12 at 9 10 20 AM

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.61%. Comparing base (9496364) to head (ba628da).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #921   +/-   ##
=======================================
  Coverage   84.61%   84.61%           
=======================================
  Files        1100     1100           
  Lines       20488    20488           
  Branches     7748     7748           
=======================================
  Hits        17335    17335           
  Misses       3066     3066           
  Partials       87       87           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rkondra-eightfold
Copy link
Contributor Author

:shipit:

@rkondra-eightfold rkondra-eightfold merged commit f0b09c2 into main Dec 12, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants