Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: menu: adds onclick handler back to main button when secondarybuttonprops fixing menu onchange #813

Conversation

dkilgore-eightfold
Copy link
Contributor

@dkilgore-eightfold dkilgore-eightfold commented Apr 11, 2024

SUMMARY:

The onClick event was deferred to the ...rest spread via MenuItemButton props, this caused a regression in Menu as the onClick callback was being used internally to trigger Menu onChange callback upstream.

BEFORE FIX:

before.mp4

AFTER FIX:

after.mp4

JIRA TASK (Eightfold Employees Only):

ENG-85650

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

Pull the PR branch and run yarn and yarn storybook. Verify the Menu stories behave as expected.

Copy link

codesandbox-ci bot commented Apr 11, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@dkilgore-eightfold dkilgore-eightfold merged commit e426ba3 into EightfoldAI:main Apr 11, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants