Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upload: adds delete button to single dropzones and other updates #775

Conversation

dkilgore-eightfold
Copy link
Contributor

@dkilgore-eightfold dkilgore-eightfold commented Jan 23, 2024

SUMMARY:

  • Adds delete button to Upload.Dropzone when in single mode
  • Updates removeFileText default from "Remove file" to "Delete"
  • Updates text sizes to match latest specification
  • Updates numerous Icon to match latest specification
  • Updates mdiFileCheck and mdiFileCheckOutline Icons to match latest specification in mdi.ts
  • Updates Upload.Dropzone margins, padding and flexGap to latest specification
  • Updates mocky.io urls (these only work locally for individual developers, might need to document and add a prop to enable people to add their own mock http response in Storybook)
  • Updates stories
  • Updates snaps
upload.mp4

JIRA TASK (Eightfold Employees Only):

ENG-75829

CHANGE TYPE:

  • Bugfix Pull Request
  • Feature Pull Request

TEST COVERAGE:

  • Tests for this change already exist
  • I have added unittests for this change

TEST PLAN:

Pull the PR branch and run yarn and yarn storybook. Verify the Upload stories behave as expected.

NOTE: This version does not include:

  • Support for replace button in multiple mode list items
  • Uploading state with only progress indicator

Copy link

codesandbox-ci bot commented Jan 23, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d127327:

Sandbox Source
React Configuration

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (74bcec2) 84.86% compared to head (d127327) 84.81%.

Files Patch % Lines
src/components/Upload/UploadList/ListItem.tsx 55.88% 15 Missing ⚠️
src/components/Upload/Upload.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #775      +/-   ##
==========================================
- Coverage   84.86%   84.81%   -0.05%     
==========================================
  Files         999      999              
  Lines       19496    19525      +29     
  Branches     7258     7281      +23     
==========================================
+ Hits        16546    16561      +15     
- Misses       2870     2884      +14     
  Partials       80       80              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dkilgore-eightfold dkilgore-eightfold merged commit 1057618 into EightfoldAI:main Jan 24, 2024
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants