Skip to content
This repository has been archived by the owner on Mar 26, 2024. It is now read-only.

Switch from grcov to cargo-llvm-cov #115

Merged
merged 1 commit into from
May 16, 2023
Merged

Switch from grcov to cargo-llvm-cov #115

merged 1 commit into from
May 16, 2023

Conversation

elasticdog
Copy link
Member

This tool provides a much better workflow compared to what we were doing with our grcov-based xtask. It's well-written, popular, and receives regular maintenance, so it should be easier to keep on top of upstream changes. It will also be trivial to add publishing to codecov.

See:

Checklist

  • Ran cargo xtask fixup for project formatting and style
  • Modified all relevant documentation
  • Updated CHANGELOG.md per "Keep a Changelog" format
  • Added tests covering my changes

@elasticdog
Copy link
Member Author

Note that I'm no longer explicitly installing the toolchain component llvm-tools-preview or mentioning it in the docs, even though it is still a requirement. The cargo-llvm-cov tool handles it in a nicer fashion, taking into account whether or not the tool is being run on CI, and I'd rather the upstream project manage its own dependency directly.

See:

@elasticdog elasticdog added this pull request to the merge queue May 16, 2023
@elasticdog elasticdog removed this pull request from the merge queue due to a manual request May 16, 2023
This tool provides a much better workflow compared to what we were doing
with our grcov-based xtask. It's well-written, popular, and receives
regular maintenance, so it should be easier to keep on top of upstream
changes. It will also be trivial to add publishing to codecov.

See:
- https://github.com/taiki-e/cargo-llvm-cov
@elasticdog elasticdog force-pushed the push-ulwxqzmyxmmt branch from 1d29975 to eaf0f8d Compare May 16, 2023 18:50
@elasticdog elasticdog enabled auto-merge May 16, 2023 18:51
@elasticdog elasticdog added this pull request to the merge queue May 16, 2023
Merged via the queue into main with commit ce13cc0 May 16, 2023
@elasticdog elasticdog deleted the push-ulwxqzmyxmmt branch May 16, 2023 19:00
@elasticdog elasticdog added enhancement New feature or request dependencies Pull requests that update a dependency file labels May 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant