cam6_4_086: Rayleigh Friction to CCPP #1245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cacraigucar
requested changes
Mar 24, 2025
cacraigucar
requested changes
Apr 4, 2025
There was a problem hiding this comment.
I realized that I never did a full review, so I have done that now. @nusbaume - please chime in your thoughts on the _cam routines. I believe they add an unnecessary layer, but it might be a convention which are trying to implement?
nusbaume
approved these changes
Apr 6, 2025
There was a problem hiding this comment.
Looks great to me now (assuming you also make @cacraigucar's changes, as I agree just calling the CCPP-ized subroutines directly is probably the best approach in this case)!
cacraigucar
requested changes
Apr 8, 2025
cacraigucar
approved these changes
Apr 14, 2025
cacraigucar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's the PR for Rayleigh Friction to CCPP!
Fixes #1153