added comment to upgrade guide

DuendeSoftware · Feb 7, 2025 · 26d11e0 · 26d11e0
1 parent 13be58f
commit 26d11e0
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/.github/workflows/bff-ci.yml b/.github/workflows/bff-ci.yml
@@ -53,7 +53,7 @@ jobs:
       run: 'ls '
       working-directory: test
     - name: Test report
-      if: success() || failure()
+      if: github.event == 'push' && (success() || failure())
       uses: dorny/test-reporter@31a54ee7ebcacc03a09ea97a7e5465a47b84aea5
       with:
         name: Test Report

diff --git a/.github/workflows/identity-server-ci.yml b/.github/workflows/identity-server-ci.yml
@@ -51,7 +51,7 @@ jobs:
       run: 'ls '
       working-directory: test
     - name: Test report
-      if: success() || failure()
+      if: github.event == 'push' && (success() || failure())
       uses: dorny/test-reporter@31a54ee7ebcacc03a09ea97a7e5465a47b84aea5
       with:
         name: Test Report

diff --git a/bff/docs/upgrade-guide.md b/bff/docs/upgrade-guide.md
@@ -99,3 +99,7 @@ a custom IAccessTokenRetriever, then you should adjust their usage accordingly.
     /// The remote address of the API.
     /// </summary>
     public required Uri ApiAddress { get; set; }
+
+### AddAddEntityFrameworkServerSideSessionsServices has been renamed to AddEntityFrameworkServerSideSessionsServices
+
+If you used the method AddAddEntityFrameworkServerSideSessionsServices() in your code, please replace it with the corrected AddEntityFrameworkServerSideSessionsServices()