Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rich-text-code): Retore original Tiptap input/paste rules #999

Merged
merged 1 commit into from
Jan 7, 2025
Merged

fix(rich-text-code): Retore original Tiptap input/paste rules #999

merged 1 commit into from
Jan 7, 2025

Conversation

rfgamaral
Copy link
Member

@rfgamaral rfgamaral commented Jan 7, 2025 •
edited by rmartins90
Loading

Overview

This PR reverts the changes introduced in this upstream PR, which modified the Markdown shortcut behaviour for inline code marks. Unfortunately, the upstream changes introduced a new bug. By reverting them on the Typist side, we avoid the bug in our products, but this also means the new behaviour will no longer be available. This will help with https://github.com/Doist/Issues/issues/15850.

PR Checklist

Test plan

  • Open the preview Storybook deployed to Netlify
  • Open the Rich-text → Default story
  • Type some text, then a space, then open/close back ticks
  • Move the cursor to be inside the backticks, and type something
  • Move the cursor to the right-side of the paragraph, press space
    • Observe that nothing happens, and the paragraph looks exactly as before

Demo

BeforeAfter
firefox_GjGhWj6Dvz.mp4
firefox_fxaHPEDAsq.mp4

@rfgamaral rfgamaral added the ⛴ Ship PR Used for PRs that don't need a review and can be merged when CI is green. label Jan 7, 2025
@rfgamaral rfgamaral self-assigned this Jan 7, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 7, 2025 •
edited
Loading

✅ Deploy Preview for doist-typist ready!

Name Link
🔨 Latest commit 80d1a57
🔍 Latest deploy log https://app.netlify.com/sites/doist-typist/deploys/677d506eb349470008522d9b
😎 Deploy Preview https://deploy-preview-999--doist-typist.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rfgamaral rfgamaral added 👀 Show PR Used for PRs that need a review, but can be merged when CI is green. and removed ⛴ Ship PR Used for PRs that don't need a review and can be merged when CI is green. labels Jan 7, 2025
@rfgamaral rfgamaral requested review from a team and rmartins90 and removed request for a team January 7, 2025 16:11
@rfgamaral rfgamaral marked this pull request as ready for review January 7, 2025 16:12
@rfgamaral rfgamaral merged commit 6673d83 into main Jan 7, 2025
11 checks passed
@rfgamaral rfgamaral deleted the ricardo/restore-code-input-and-paste-rules branch January 7, 2025 16:15
doistbot added a commit that referenced this pull request Jan 7, 2025
@doistbot
chore(release): 7.0.6 [skip ci]
8307f4d 
## [7.0.6](v7.0.5...v7.0.6) (2025-01-07)

### Bug Fixes

* **rich-text-code:** Retore original Tiptap input/paste rules ([#999](#999)) ([6673d83](6673d83))
@doistbot
Copy link
Member

doistbot commented Jan 7, 2025

🎉 This PR is included in version 7.0.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@doistbot doistbot added the released Pull requests that have been released to production label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmartins90 rmartins90 Awaiting requested review from rmartins90 rmartins90 was automatically assigned from Doist/frontend-product

Assignees

@rfgamaral rfgamaral

Labels
released Pull requests that have been released to production 👀 Show PR Used for PRs that need a review, but can be merged when CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rfgamaral @doistbot