Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(observability): avoid panics caused by missing labels #213

Merged
merged 6 commits into from
Dec 10, 2021

Conversation

Reasno
Copy link
Member

@Reasno Reasno commented Dec 10, 2021

No description provided.

@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #213 (5c066c0) into master (60953bf) will decrease coverage by 0.14%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #213      +/-   ##
==========================================
- Coverage   82.39%   82.25%   -0.15%     
==========================================
  Files          92       92              
  Lines        3465     3494      +29     
==========================================
+ Hits         2855     2874      +19     
- Misses        455      460       +5     
- Partials      155      160       +5     
Impacted Files Coverage Δ
observability/observability.go 100.00% <ø> (ø)
otkafka/reader_metrics.go 97.53% <33.33%> (-2.47%) ⬇️
otkafka/writer_metrics.go 95.40% <33.33%> (-2.25%) ⬇️
srvgrpc/metrics.go 77.41% <60.00%> (-18.24%) ⬇️
observability/metrics.go 100.00% <100.00%> (ø)
otgorm/gorm_metrics.go 100.00% <100.00%> (ø)
otredis/metrics.go 100.00% <100.00%> (ø)
srvhttp/metrics.go 84.61% <100.00%> (+0.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60953bf...5c066c0. Read the comment docs.

@Reasno Reasno requested a review from GGXXLL December 10, 2021 07:02
@Reasno Reasno changed the title docs: update the example to reflect the new way of using metrics. refactor(srvhttp): make histogram in RequestDurationSeconds private Dec 10, 2021
@Reasno Reasno removed the request for review from GGXXLL December 10, 2021 07:37
@Reasno Reasno marked this pull request as draft December 10, 2021 07:37
@Reasno Reasno changed the title refactor(srvhttp): make histogram in RequestDurationSeconds private refactor(observability): avoid panics caused by missing labels Dec 10, 2021
@Reasno Reasno marked this pull request as ready for review December 10, 2021 08:23
@Reasno Reasno requested a review from GGXXLL December 10, 2021 08:40
@Reasno Reasno merged commit 49d5b2f into master Dec 10, 2021
@Reasno Reasno deleted the observability branch December 10, 2021 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants