Update burst-buffer plugin for Slurm 23.02.7 #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In burst_buffer.lua: Change slurm_bb_job_process() to create the real Workflow. The 23.02 burst-buffer API allows this function to create the real thing rather than forcing us to make a temporary throw-away Workflow. Change slurm_bb_setup() to acccept the Workflow created by slurm_bb_job_process(). Minor updates for other API changes. In burst_buffer.lua.example: Update from the Slurm 23.02.7 repo. In burst_buffer/dws-test.lua: Update for changes to slurm_bb_job_process() and slurm_bb_setup(). Some things were dropped form this test; maintenance on the kubectl-mocking code is ridiculously difficult and we need a different approach for this. In testsuite/integration/src/tests: Address some lint warnings. Fix a bug in wait_until_job_has_been_x(). In testsuite/integration/slurm/docker-compose.yml and testsuite/submodules/slurm-docker-cluster: Update to build slurm 23.02.7.1. Signed-off-by: Dean Roehrich <[email protected]>
The tests work when run on my Mac. On github, the slurmctld container can contact the k8s api server but the sbatch command is getting killed when it tries to submit a job to slurm. Signed-off-by: Dean Roehrich <[email protected]>
roehrich-hpe
force-pushed
the
slurm-23-02-7
branch
from
32e25de to
466f0a6
Compare
|
This is ready now. |
bdevcich
reviewed
Apr 2, 2024
| #publish-integration-test: | ||
| # uses: ./.github/workflows/publish-integration-test.yml | ||
| # needs: integration-test |
There was a problem hiding this comment.
Nope. This is something to come back to later.
bdevcich
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In burst_buffer.lua:
Change slurm_bb_job_process() to create the real Workflow. The 23.02 burst-buffer API allows this function to create the real thing rather than forcing us to make a temporary throw-away Workflow. Change slurm_bb_setup() to acccept the Workflow created by slurm_bb_job_process(). Minor updates for other API changes.
In burst_buffer.lua.example:
Update from the Slurm 23.02.7 repo.
In burst_buffer/dws-test.lua:
Update for changes to slurm_bb_job_process() and slurm_bb_setup(). Some things were dropped form this test; maintenance on the kubectl-mocking code is ridiculously difficult and we need a different approach for this.
In testsuite/integration/src/tests:
Address some lint warnings. Fix a bug in wait_until_job_has_been_x().
In testsuite/integration/slurm/docker-compose.yml and testsuite/submodules/slurm-docker-cluster:
Update to build slurm 23.02.7.1.