Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capabilities tests should be stricter #4022

Merged
merged 2 commits into from
Feb 18, 2025
Merged

Conversation

bm1549
Copy link
Contributor

@bm1549 bm1549 commented Feb 7, 2025

Motivation

Some products have added capabilities that were not registered on our backend, which means that they are not usable
Some languages allow higher than 64-bit capabilities, which could cause problems down the line

Changes

  • Tests that capabilities are at most 64 bits
  • Tests that all capabilities received are part of the list maintained in system tests (to be added later on - a check against capabilities.go)
  • Exhaustive check for all capabilities provided by default across different libraries
  • Adds typing to LibraryVersion to make it clearer how it should be used
  • Adds missing Capabilities (as seen in dd-trace-java)

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@bm1549 bm1549 force-pushed the brian.marks/safer-capabilities branch 3 times, most recently from 0255819 to 07a16a8 Compare February 14, 2025 14:22
@bm1549 bm1549 force-pushed the brian.marks/safer-capabilities branch from 8686004 to 8ff33c1 Compare February 14, 2025 21:12
@bm1549 bm1549 marked this pull request as ready for review February 14, 2025 21:15
@bm1549 bm1549 requested review from mabdinur and a team as code owners February 14, 2025 21:15
@bm1549 bm1549 merged commit dfe6f03 into main Feb 18, 2025
333 of 336 checks passed
@bm1549 bm1549 deleted the brian.marks/safer-capabilities branch February 18, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants