Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python graphql error spans testing #3968

Merged
merged 13 commits into from
Feb 13, 2025

Conversation

quinna-h
Copy link
Contributor

@quinna-h quinna-h commented Feb 3, 2025

Motivation

Changes

  • Adds a /graphql endpoint to the flask-poc weblog app
  • Enables testing graphql error spans
  • Update flask-poc and uwsgi-poc base images

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@quinna-h quinna-h changed the title [WIP] python graphql error spans python graphql error spans testing Feb 5, 2025
@quinna-h quinna-h requested a review from marcotc February 5, 2025 22:43
Copy link
Member

@marcotc marcotc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@quinna-h quinna-h marked this pull request as ready for review February 6, 2025 17:00
@quinna-h quinna-h requested review from a team as code owners February 6, 2025 17:00
@quinna-h quinna-h requested review from ZStriker19 and mabdinur and removed request for a team February 6, 2025 17:00
Copy link
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure in CI

@quinna-h quinna-h force-pushed the quinna.halim/python-graphql-error-spans branch from 168a528 to 5488563 Compare February 12, 2025 17:53
@quinna-h quinna-h merged commit 0937eb8 into main Feb 13, 2025
436 checks passed
@quinna-h quinna-h deleted the quinna.halim/python-graphql-error-spans branch February 13, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants