OnBoarding: de-parametrize #3960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbeauchesne
requested changes
Feb 5, 2025
cbeauchesne
requested changes
Feb 10, 2025
tests/docker_ssi/test_docker_ssi.py
Outdated
| @@ -52,7 +52,7 @@ def setup_install_weblog_running(self): | |||
|
|
|||
| @features.ssi_guardrails | |||
| @bug( | |||
| condition="centos-7" in context.scenario.weblog_variant and context.scenario.library.library == "java", | |||
| condition="centos-7" in context.weblog_variant and context.scenario.library.library == "java", | |||
There was a problem hiding this comment.
This should be working in theory:
Suggested change
| condition="centos-7" in context.weblog_variant and context.scenario.library.library == "java", | |
| condition="centos-7" in context.weblog_variant and context.library == "java", |
| @@ -19,6 +19,7 @@ | |||
|
|
|||
| import socket | |||
| import time | |||
| from utils.tools import logger | |||
|
|
|||
|
|
|||
| def wait_for_port(port: int, host: str = "localhost", timeout: float = 5.0): | |||
There was a problem hiding this comment.
Probaly a better name : wait_for_accepting_connection
There was a problem hiding this comment.
for the next pr
cbeauchesne
force-pushed
the
robertomonteromiguel/onboarding_deparametrize
branch
from
4638612 to
897ca43
Compare
robertomonteromiguel
deleted the
robertomonteromiguel/onboarding_deparametrize
branch
robertomonteromiguel
added a commit
that referenced
this pull request
Mar 17, 2025
Co-authored-by: Charles de Beauchesne <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
we no longer run multiple virtual machines by scenario. We don't need parametrize the tests. The current VM data is stored in the scenario.
Changes
Workflow
codeownersfile quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present