Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Nodejs telemetry metric for code injection #3948

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

IlyasShabi
Copy link
Contributor

Motivation

Enable Telemetry metric instrumented test for Node.js

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@IlyasShabi IlyasShabi marked this pull request as ready for review January 31, 2025 15:19
@IlyasShabi IlyasShabi requested review from a team as code owners January 31, 2025 15:19
@IlyasShabi IlyasShabi merged commit 81c51e5 into main Jan 31, 2025
283 of 284 checks passed
@IlyasShabi IlyasShabi deleted the code-injection-telemetry-metric branch January 31, 2025 15:29
IlyasShabi added a commit that referenced this pull request Jan 31, 2025
@IlyasShabi IlyasShabi restored the code-injection-telemetry-metric branch February 3, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants