[python] Enable more user event tests #3935
Merged
+14
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nable_user_blocking_for_python
2 tasks
christophe-papazian
added a commit
to DataDog/dd-trace-py
that referenced
this pull request
Jan 31, 2025
This PR improve user blocking on Django by adding the possibility to block a previously authentified user. - Wrap AuthenticationMiddleware.process_request to check at the start of a new request, if an authentified user was already found and run the WAF on it. Ensure this patch is compatible with APM patches of middleware - Ensure the new way of blocking requests does not interfere with the old way on set_user, by allowing set_user blocking to be bypassed. We want to be sure we call the WAF exactly once. - Add support for "_dd.appsec.user.collection_mode" tag - Those changes will be tested and tracked by several system tests: - `tests/appsec/test_automated_user_and_session_tracking.py::Test_Automated_User_Tracking` - `tests/appsec/test_automated_user_and_session_tracking.py::Test_Automated_User_Blocking::test_user_blocking_auto` DataDog/system-tests#3935 APPSEC-56505 ## Checklist - [x] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) --------- Co-authored-by: Yun Kim <[email protected]> Co-authored-by: Nicole Cybul <[email protected]> Co-authored-by: Nick Ripley <[email protected]> Co-authored-by: William Conti <[email protected]>
christophe-papazian
requested review from
juanjux and
quinna-h
and removed request for
a team
cbeauchesne
approved these changes
Jan 31, 2025
christophe-papazian
deleted the
christophe-papazian/enable_user_blocking_for_python
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After DataDog/dd-trace-py#12069 will be merged, this PR enables more tests for ATO on Python.
Changes
ALSO FOR PYTHON:
use 3.x-staging for dev branch during transition before 3.0 major release.
Workflow
codeownersfile quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present