Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[golang] new orchestrion go weblog #3555

Merged
merged 16 commits into from
Jan 30, 2025
Merged

Conversation

eliottness
Copy link
Contributor

@eliottness eliottness commented Nov 26, 2024

Motivation

Provide simple testing features for https://github.com/DataDog/orchestrion

Changes

  • Copy-paste of the net-http variant into a net-http-orchestrion variant
  • Removal of all dd-trace-go SDK usage in this new variant
  • Creating a new install_orchestrion.sh script in the go weblog
  • Adding utility features for orchestrion for feature parity with the tracer
  • Changed 1 testsuite that had behaviour hardcoded for variant names
  • Disable all the same tests that could not pass because of net-http lack of path params

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@eliottness eliottness force-pushed the eliottness/orchestrion-net-http branch from fadae61 to 700c3dc Compare January 9, 2025 16:13
@eliottness eliottness changed the title [golang] switch go weblog to orchestrion [golang] new orchestrion go weblog Jan 9, 2025
@eliottness eliottness added the go Pull requests that update Go code label Jan 9, 2025
@eliottness eliottness force-pushed the eliottness/orchestrion-net-http branch 4 times, most recently from 37dfad8 to 6828384 Compare January 13, 2025 10:21
@eliottness eliottness force-pushed the eliottness/orchestrion-net-http branch from a8da4af to 17d6dbb Compare January 23, 2025 09:17
Signed-off-by: Eliott Bouhana <[email protected]>

copy net-http into net-http-orchestrion

Signed-off-by: Eliott Bouhana <[email protected]>

revert net-http

Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
@eliottness eliottness force-pushed the eliottness/orchestrion-net-http branch from ec8ecd9 to fca0743 Compare January 24, 2025 09:34
@RomainMuller RomainMuller marked this pull request as ready for review January 29, 2025 17:02
@RomainMuller RomainMuller requested review from a team as code owners January 29, 2025 17:02
Copy link
Collaborator

@cbeauchesne cbeauchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Globally, LGTM, i'v just two questions before approving

utils/scripts/load-binary.sh Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
@RomainMuller RomainMuller merged commit 60a1b57 into main Jan 30, 2025
44 checks passed
@RomainMuller RomainMuller deleted the eliottness/orchestrion-net-http branch January 30, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants