-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[golang] new orchestrion go weblog #3555
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliottness
force-pushed
the
eliottness/orchestrion-net-http
branch
from
January 9, 2025 16:13
fadae61
to
700c3dc
Compare
eliottness
changed the title
[golang] switch go weblog to orchestrion
[golang] new orchestrion go weblog
Jan 9, 2025
eliottness
force-pushed
the
eliottness/orchestrion-net-http
branch
4 times, most recently
from
January 13, 2025 10:21
37dfad8
to
6828384
Compare
eliottness
force-pushed
the
eliottness/orchestrion-net-http
branch
from
January 23, 2025 09:17
a8da4af
to
17d6dbb
Compare
Signed-off-by: Eliott Bouhana <[email protected]> copy net-http into net-http-orchestrion Signed-off-by: Eliott Bouhana <[email protected]> revert net-http Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
Signed-off-by: Eliott Bouhana <[email protected]>
eliottness
force-pushed
the
eliottness/orchestrion-net-http
branch
from
January 24, 2025 09:34
ec8ecd9
to
fca0743
Compare
Don't run fancy-report if cancelled.
RomainMuller
approved these changes
Jan 29, 2025
RomainMuller
approved these changes
Jan 29, 2025
RomainMuller
approved these changes
Jan 29, 2025
cbeauchesne
reviewed
Jan 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Globally, LGTM, i'v just two questions before approving
cbeauchesne
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Provide simple testing features for https://github.com/DataDog/orchestrion
Changes
net-http
variant into anet-http-orchestrion
variantinstall_orchestrion.sh
script in the go weblogWorkflow
codeowners
file quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>]
, double-check that only<language>
is impacted by the changebuild-XXX-image
label is present