Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONTINT-4500] [helm] Add EKS Clusterrole Rule for EKS control plane metrics #1686

Merged
merged 2 commits into from
Feb 4, 2025
Merged

[CONTINT-4500] [helm] Add EKS Clusterrole Rule for EKS control plane metrics #1686

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04ad37f
Add rule to clusterrole so the node agent can query the EKS control p…
justin-lesko Feb 3, 2025
f2b0195
Update README to reflect the new chart version
justin-lesko Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions charts/datadog/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Datadog changelog

## 3.90.1

* Add rule to clusterrole to allow the node agent to query the EKS control plane metrics API

## 3.90.0

* Set default `Agent` and `Cluster-Agent` version to `7.62.0`.
Expand Down
2 changes: 1 addition & 1 deletion charts/datadog/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
apiVersion: v1
name: datadog
version: 3.90.0
version: 3.90.1
appVersion: "7"
description: Datadog Agent
keywords:
Expand Down
2 changes: 1 addition & 1 deletion charts/datadog/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Datadog

![Version: 3.90.0](https://img.shields.io/badge/Version-3.90.0-informational?style=flat-square) ![AppVersion: 7](https://img.shields.io/badge/AppVersion-7-informational?style=flat-square)
![Version: 3.90.1](https://img.shields.io/badge/Version-3.90.1-informational?style=flat-square) ![AppVersion: 7](https://img.shields.io/badge/AppVersion-7-informational?style=flat-square)

[Datadog](https://www.datadoghq.com/) is a hosted infrastructure monitoring platform. This chart adds the Datadog Agent to all nodes in your cluster via a DaemonSet. It also optionally depends on the [kube-state-metrics chart](https://github.com/prometheus-community/helm-charts/tree/main/charts/kube-state-metrics). For more information about monitoring Kubernetes with Datadog, please refer to the [Datadog documentation website](https://docs.datadoghq.com/agent/basic_agent_usage/kubernetes/).

Expand Down
7 changes: 7 additions & 0 deletions charts/datadog/templates/rbac.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,13 @@ rules:
resources: ["secrets"]
verbs: ["get"]
{{- end }}
- apiGroups: # EKS kube_scheduler and kube_controller_manager control plane metrics
- "metrics.eks.amazonaws.com"
resources:
- kcm/metrics
- ksh/metrics
verbs:
- get
Comment on lines +132 to +138
Copy link
Collaborator

@clamoriniere clamoriniere Feb 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure but this clusterrole is also use for the cluster-check-runner service account https://github.com/DataDog/helm-charts/blob/main/charts/datadog/templates/agent-clusterchecks-rbac.yaml so it should be ok when the check run as cluster check

---
apiVersion: {{ template "rbac.apiVersion" . }}
kind: ClusterRoleBinding
Expand Down