fix(datadog): RBAC for resources labels/annotations as tags #1685
+11
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This fixes two issues with how the chart it rendered when
datadog.kubernetesResourcesAnnotationsAsTags
and/ordatadog.kubernetesResourcesLabelsAsTags
are used:.
were incorrectly rendered, as is frequently used with CRDs.DD_KUBERNETES_RESOURCES_ANNOTATIONS_AS_TAGS
Which issue this PR fixes
Special notes for your reviewer:
I verified the fix using helm template and the following values:
The RBAC rules were correctly rendered as:
And the cluster-agent env vars are correct:
Checklist
.github/helm-docs.sh
)CHANGELOG.md
has been updated