-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic userID tracking and blocking #4670
Merged
Merged
Changes from 1 commit
Commits
Show all changes
163 commits
Select commit
Hold shift + click to select a range
81f6ab5
instrument passport
simon-id 023828c
lint
simon-id 98090fb
update config
simon-id 5cc7274
add new RC capability
simon-id 3343878
Merge branch 'master' into new_user_collection
simon-id 4e127de
add RC handler
simon-id b4daf8f
fix require path
simon-id 5f85b8e
add setCollectionMode()
simon-id 1b074ad
use setCollectionMode() in appsec index
simon-id cbc8cf3
DRY up passport strategies instrumentation
simon-id 729241d
simplify passport strategies instrumentations
simon-id 6ffc21f
simplify instrumentation
simon-id 4433baa
note for later
simon-id cf39858
add blocking to login
simon-id 2da5bef
Merge branch 'master' into new_user_collection
simon-id d8bed47
add abortController in listener
simon-id 5105006
cleanup
simon-id 65c680b
update typings
simon-id 23f965d
cleanup
simon-id b5b336a
RC config update
simon-id 53a7791
push everything
simon-id 2b7d2e6
simplify passport strategies instrumentation
simon-id 24c2828
fixes
simon-id cdb89f6
simplify code
simon-id 32edfae
cleanup
simon-id 50b3605
revert some changes
simon-id b5aa0d4
delete passport.js
simon-id 1f30a3c
Update packages/datadog-instrumentations/src/passport-utils.js
simon-id 9fee2bc
update verify subscriber
simon-id be3115a
rollback config changes
simon-id 38b4419
fix config
simon-id 40c9df1
add blocking for passport strategies
simon-id e34bb72
update typings and docs
simon-id d255702
update appsec index
simon-id b6d4584
update RC
simon-id 75782f9
Merge branch 'master' into new_user_collection
simon-id 4ff8379
push some stuff
simon-id be473e6
push some stuff
simon-id 4a566a8
cleanup
simon-id 882bc8b
cleanup
simon-id d4345ef
add new usr.login waf address
simon-id be4a06c
commit some stuff
simon-id f129890
cleanup
simon-id 58897c8
Merge branch 'new_user_collection' into automatic_userid_blocking
simon-id cceac23
cleanup
simon-id 654d260
add comment for later
simon-id 066da87
add some ideas
simon-id da9b270
cleanup
simon-id 01c8240
aaaaa
simon-id cc86e3a
pass abort controller for blocking
simon-id 69d12a9
push some notes
simon-id ce604c1
change config default
simon-id 56c30e8
handle duplicate RC confs for auto_user_instrum.mode
simon-id 1d3773a
refactor sdk/track_event.js to only be used by the SDK
simon-id a9f5c01
Merge branch 'new_user_collection' into automatic_userid_blocking
simon-id a72695f
push some stuff
simon-id 91a59db
remove some comments
simon-id faea3aa
pass login to WAF in SDK login success event
simon-id fe70c84
add comments
simon-id e32f78e
add framework name to passport strategy instrum
simon-id 806ab23
add framework name and waf handleResults() to onPassportVerify()
simon-id 69be031
Merge branch 'master' into new_user_collection
simon-id 1e1bb47
finally commit trackLogin()
simon-id 8eac055
fix tag override condition
simon-id a444cfe
add telemetry function
simon-id 187b42f
Merge branch 'master' into new_user_collection
simon-id 72a4a8b
Merge branch 'master' into new_user_collection
simon-id 9fa94f6
move user_tracking into a file instead of a subfolder
simon-id d51e434
Merge branch 'master' into new_user_collection
simon-id 8b22248
remove changes
simon-id 25abd50
temp revert changes
simon-id 52a0601
temp revert changes
simon-id b72ce34
Merge branch 'new_user_collection' into automatic_userid_blocking
simon-id 5a10fc0
fix conflict
simon-id 9869c4b
wrong file
simon-id 76e2e65
add some stuff
simon-id 80ae693
push some stuff
simon-id 7e3374d
Use addresses enum instead of hardcoded business logic events
simon-id c099a2a
Update default value of collection mode in typings
simon-id 96cb722
Add string check in getUserId()
simon-id 0a347e8
Merge branch 'master' into new_user_collection
simon-id 85ad6f2
fix existing RC tests
simon-id 70dcbab
add tests for RC collection mode
simon-id ff72271
fix env var ordering
simon-id 7338bd6
cleanup track_event.spec.js
simon-id b71ed06
do not export or test trackEvent()
simon-id 166bc23
update test, cleanup, and add missing coverage
simon-id a93b79a
change ordering of code to match tests
simon-id a83c4fb
delete passport-utils tests because it's useless
simon-id 6cf7ef2
fix test to correctly use passReqToCallback
simon-id 29c0d62
update passport-local tests
simon-id a6211b2
Merge branch 'new_user_collection' into automatic_userid_blocking
simon-id afafb8a
update tests for passpot-http
simon-id 956cb9b
allow empty login strings
simon-id 62ae42b
update TS tests
simon-id 375f688
update telemetry tests
simon-id 79a7ff5
Merge branch 'new_user_collection' into automatic_userid_blocking
simon-id b47e44a
Merge branch 'master' into automatic_userid_blocking
simon-id 5a0ee2e
push stuff
simon-id 775bf9a
remove session id support
simon-id cb78746
add telemetry function
simon-id a259b22
use telemetry
simon-id 96cf8e7
cleanup
simon-id c519d6e
bad copy paste
simon-id 8767533
remove comments
simon-id a508649
fix sdk
simon-id 42d9fda
cleanup
simon-id d643691
cleanup
simon-id d910370
cleanup
simon-id 28254ce
better original res.end call
simon-id 2ec2e5b
revert old copy paste or something
simon-id bd3a597
cleanup
simon-id bc2b2d0
cleanup
simon-id be29564
Merge branch 'master' into automatic_userid_blocking
simon-id c0ae70b
cleanup
simon-id 60789f4
don't put user tracking tag when calling login tracking
simon-id 1cb83fb
Merge branch 'master' into automatic_userid_blocking
simon-id 03e18df
Merge branch 'master' into automatic_userid_blocking
simon-id 8c3e97b
add telemetry test
simon-id 7adb49a
fix blocking tests
simon-id d80b41c
fix appsec index blocking tests
simon-id 8dfbb3d
fix setuser tests
simon-id 1beff4f
remove outdated test
simon-id 2dd9cb5
fix user blocking test
simon-id 8eea578
Merge branch 'master' into automatic_userid_blocking
simon-id be219e1
trackUser() tests
simon-id 115e808
update set_user tests
simon-id 09aadcd
update user blocking tests
simon-id 589271d
update appsec index tests
simon-id 67482db
lint
simon-id b51c666
Merge branch 'master' into automatic_userid_blocking
simon-id 1fe6b89
add passport in ci tests
simon-id e600ec0
try to break a test
simon-id f00dfbe
try to break another test
simon-id c203530
Merge branch 'master' into automatic_userid_blocking
simon-id 0b15e9b
Update passport-http.spec.js
simon-id 24328ab
add express-session in the whitelist of WeakHashAnalyzer
simon-id 2ee8209
fix passport instrmentation tests not run in CI
simon-id 89b9cfe
revert debug
simon-id 14d6760
upload non finished passport test to check CI
simon-id 0310e40
revert autoformat
simon-id 0c51a40
cleanup
simon-id 94a3d1e
cleanup
simon-id f8e9720
Merge branch 'master' into automatic_userid_blocking
simon-id ae6d2ed
fix test file
simon-id b7dedaf
fix passport tests
simon-id d02ed23
no need for any plugin in passport tests
simon-id 9d3ab11
actually we need http
simon-id 24c8515
update blocking test
simon-id 42204c7
little cleanup
simon-id 242bc86
fix the final test
simon-id e35e3b9
change oldest supported version of passport
simon-id bfa5c9a
cleanup
simon-id 3663b2c
update test externals
simon-id 4c6d0fd
no need to check
simon-id d8daec1
Merge branch 'master' into automatic_userid_blocking
simon-id 18f339a
Merge branch 'master' into automatic_userid_blocking
simon-id 780b68a
move passport tests jobs to new file
simon-id b088603
don't pass usr.login to waf in setUser()
simon-id cb4ceb6
fix test for previous commit
simon-id 9b1a4eb
Merge branch 'master' into automatic_userid_blocking
simon-id 86718b7
Merge branch 'master' into automatic_userid_blocking
simon-id b9ffe92
Merge branch 'master' into automatic_userid_blocking
simon-id File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
push some stuff
- Loading branch information
commit 80ae6930bd2895e27203b61390ffc28e0e5269d4
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
options.session can be used to know if it's login or session or not ?