RUMM-1000 Use View.customTimings from actual schema instead of RUMEvent #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 8, 2021 15:24
…e for the View model
… and use View.customTimings instead
ncreated
approved these changes
Feb 9, 2021
Comment on lines
+36
to
+42
| protocol AnyMockable { | ||
| static func mockAny() -> Self | ||
| } | ||
|
|
||
| protocol RandomMockable { | ||
| static func mockRandom() -> Self | ||
| } |
There was a problem hiding this comment.
Nice 💪! I feel that we could even push this further with some level of code generation in the future 💡.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
The JSON Schema for RUM Event models "custom timings" of a view using the
additionalPropertieskeyword of the JSON Schema spec.This keyword was not supported until #399, and prior to that the SDK had to use a few workarounds to store the custom timings in memory until the eventual encoding into JSON.
In this PR we leverage #399 to remove the workarounds and directly encode
customTimingsfromViewmodels.How?
In this PR we:
customTimings423f095Review checklist