Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "Change Windows Containers to Windows Server Nano"" #5898

Conversation

julien-lebot
Copy link
Contributor

Reverts #5589 since giampaolo/psutil#1768 has been merged.

Copy link
Contributor

@albertvaka albertvaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to bump the dependencies on psutils (I think they all are in integrations-core) to include the fixed version as well.

@tonyredondo
Copy link
Member

Hi! ✋ do you know what is this PR missing to get merged? We are working in the CI/CD integration project and launching the agent in a windows pipeline take too long due the image size, we think this would help us a lot.

@mx-psi
Copy link
Member

mx-psi commented Aug 19, 2020

I believe we just have to bump psutil, let me open a PR for that.

@tonyredondo
Copy link
Member

I believe we just have to bump psutil, let me open a PR for that.

Great! and I've just saw that it got merged! 🎉

@julien-lebot julien-lebot force-pushed the revert-5589-revert-5488-albertvaka/containerized-windows-nano branch from 5efd000 to 6adc00e Compare August 20, 2020 09:54
@julien-lebot
Copy link
Contributor Author

I've ran some sanity checks on datadog/agent-dev:revert-5589-revert-5488-albertvaka-containerized-windows-nano-py3-win1809 and the agent seems to be working fine, so I'm going to go ahead and merge this.

@julien-lebot julien-lebot merged commit fa1ffdc into master Aug 20, 2020
@julien-lebot julien-lebot deleted the revert-5589-revert-5488-albertvaka/containerized-windows-nano branch August 20, 2020 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants