Skip to content

Add skip check on sysprobe set_fact tasks #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2020

Conversation

KSerrania
Copy link
Contributor

What does this PR do?

Adds when: not datadog_skip_running_check to the system-probe set_fact tasks.

Motivation

The datadog_sysprobe_installed and datadog_sysprobe_enabled facts are only used on tasks with the when: not datadog_skip_running_check condition.
Fixes the CI (as it needs to skip the running check).

Copy link
Contributor

@albertvaka albertvaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did this code get in, if it didn't pass the CI, though?

@KSerrania
Copy link
Contributor Author

Seems like CircleCI does not run on external contributors' branches from forks (I can't find the jobs that would be associated with #255 neither here: https://circleci.com/gh/DataDog/ansible-datadog nor here: https://circleci.com/gh/dv9io0o/ansible-datadog)

@kevinconaway
Copy link
Contributor

Won't this break the tasks below that rely on those two facts to exist? This would preclude the facts from being defined which will break the checks the below.

@KSerrania
Copy link
Contributor Author

Won't this break the tasks below that rely on those two facts to exist? This would preclude the facts from being defined which will break the checks the below.

@kevinconaway The two tasks that require these facts also have the when: not datadog_skip_running_check filter, so they won't try to evaluate these facts when datadog_skip_running_check is set to true (thanks to lazy evaluation of the conditions). You can check the CI, which runs with datadog_skip_running_check: true.

@KSerrania KSerrania merged commit 7ddf325 into master Feb 10, 2020
@KSerrania KSerrania deleted the kserrania/fix-sysprobe-check-ci branch February 10, 2020 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants