Fixes issue #10 where empty N and FN fields would throw an error #15
Conversation
…n error Now just returns an empty string
|
|
||
|
|
||
| (describe "contact-no-name" | ||
| (it "contacts without FN or F should return empty string" |
There was a problem hiding this comment.
can you please move this it to the describe called "knows how to extract a contact's fullname" and rename it to "when there is neither FN nor F"?
| @@ -84,9 +84,11 @@ Return nil if PROPERTY is not in CONTACT." | |||
| "Return the fullname of CONTACT." | |||
| (or | |||
| (vdirel--contact-property "FN" contact) | |||
| (if (equal (vdirel--contact-property "N" contact) nil) | |||
There was a problem hiding this comment.
I would prefer a different code structure (untested):
(or
(vdirel--contact-property "FN" contact)
(let ((name (vdirel--contact-property "N" contact)))
(when name
(replace-regexp-in-string ";" " " name)))
"")
|
Can you please also rebase your branch on top of latest |
|
Next time, I suggest you follow the best practices to open a PR, it will make both our lifes easier :-). No need to change this PR though, it's ok. |
|
I have addressed this differently in #18 (I wasn't aware of this PR), where we just return the email address for the name to at least give us something in case |
|
I'm closing this PR as the author isn't responding. |
Now just returns an empty string