Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linescan example to jigsaw #4727

Merged
merged 3 commits into from
Dec 30, 2021
Merged

Conversation

scsides
Copy link
Contributor

@scsides scsides commented Dec 28, 2021

Added an example using a line scan instrument to jigsaw's documentation.

Description

This new example includes the command line for running a simple jigsaw using four CTX images

Related Issue

#4718

Motivation and Context

Jigsaw needs better documentation.

How Has This Been Tested?

Documentation has been built locally.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have added myself to the .zenodo.json document.
  • I have added any user impacting changes to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

@ladoramkershner
Copy link
Contributor

High level question, should this be going into upstream/bundle_lidar, as opposed to upstream/dev?

@jessemapel
Copy link
Contributor

This should be going straight into dev because it's not connected to any of the LiDAR work. I like that this is just a simple basic example that doesn't add any extra "fluff". It would be nice if it included some output files but it's not required.

@scsides scsides merged commit 0ec76e9 into DOI-USGS:dev Dec 30, 2021
scsides added a commit to scsides/ISIS3 that referenced this pull request Jan 7, 2022
* Add linescan example to jigsaw

* Minor update

* Added to the change log for jigsaw examples
@scsides scsides deleted the jigsaw_linescan branch March 8, 2022 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants