Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added deprecation notice to edrget + changelog #4641

Merged
merged 2 commits into from
Sep 23, 2021

Conversation

AustinSanders
Copy link
Contributor

Added deprecation notice to edrget + changelog

Description

Added deprecation notice to edrget + changelog. In order to close the edrget deprecation issue, we also need to add a section in the release process (in wiki).

Looks like my previous changelog edit also sneaked into this PR. It should be included in the changelog anyway...

Related Issue

#3313

Motivation and Context

edrget does not provide functionality beyond that of wget

How Has This Been Tested?

edrget now produces a deprecation warning when it is run

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have added myself to the .zenodo.json document.
  • I have added any user impacting changes to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

Copy link
Collaborator

@acpaquette acpaquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! The only other thing I can think of is to pipe this same warning message similar to this to the application log, but if edrget is mainly used as a command line util then this looks ready to go!

@AustinSanders AustinSanders merged commit f4129b0 into DOI-USGS:dev Sep 23, 2021
@jlaura jlaura mentioned this pull request Nov 3, 2021
3 tasks
acpaquette pushed a commit to acpaquette/ISIS3 that referenced this pull request Nov 8, 2021
* Updated changelog with edrget deprecation

* Added deprecation notice

Co-authored-by: Austin Sanders <[email protected]>
acpaquette pushed a commit to acpaquette/ISIS3 that referenced this pull request Nov 15, 2021
* Updated changelog with edrget deprecation

* Added deprecation notice

Co-authored-by: Austin Sanders <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants