Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Kaguya instrument serial number support #4365

Merged
merged 4 commits into from
Mar 16, 2021
Merged

Conversation

scsides
Copy link
Contributor

@scsides scsides commented Mar 15, 2021

Added/modified the translations files to support Kaguya TC1/2 and MI instruments

Modified Instruments.trn to translate the Kaguya instruments, and added the MI and TC serial number files.

Related Issue

#4235

Motivation and Context

Control requires ISIS serial numbers. Without this change serial numbers could not be created.

How Has This Been Tested?

This was tested with several TC1, TC2, and MI images. The label contents were verified against generated serial number.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have added myself to the .zenodo.json document.
  • I have added any user impacting changes to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

@scsides scsides requested review from krlberry and kaitlyndlee March 15, 2021 22:09
jessemapel
jessemapel previously approved these changes Mar 16, 2021
@@ -8,22 +8,21 @@
# The Group names can NOT be repeated.
#
# InputGroup is a comma delimited list of objects and/or
# groups in the foreign label. Traversing this list will
# lead to the correct level to find the foreign keyword.
# groups in the inut label. Traversing this list will
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inut -> input

krlberry
krlberry previously approved these changes Mar 16, 2021
Copy link
Contributor

@krlberry krlberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good!

@scsides scsides dismissed stale reviews from krlberry and jessemapel via 21e75d8 March 16, 2021 18:01
@jessemapel jessemapel merged commit b8517dc into DOI-USGS:dev Mar 16, 2021
@scsides scsides deleted the getsn branch March 8, 2022 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants