Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed histogram binning logic #3918

Merged
merged 9 commits into from
Jun 12, 2020

Conversation

AustinSanders
Copy link
Contributor

Description

This is a continuation of PR #3914. Credit to @kaitlyndlee for the majority of content in this PR.

The math for calculating what bin data should be placed in and how Histogram calculated the min/max values of each bin seemed off. The math changed slightly to be more intuitive. In addition, the output of hist and cnethist changed to display the min/max values of each bin instead of the middle pixel's DN.

Related Issue

#3882

Motivation and Context

Makes hist and cnethist behave in the way users expect them to.

How Has This Been Tested?

5 application tests failed. Truth data has been updated locally and all app tests are passing.

The full suite of tests is running at time of PR entry. Test failures are expected due to changes to Histogram.cpp.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

@AustinSanders AustinSanders merged commit 9229634 into DOI-USGS:dev Jun 12, 2020
jessemapel added a commit that referenced this pull request Jun 15, 2020
krlberry pushed a commit that referenced this pull request Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants