Skip to content

Commit

Permalink
Addressed PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
acpaquette committed Oct 2, 2020
1 parent 6c2036f commit d6e7c25
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 9 deletions.
8 changes: 4 additions & 4 deletions isis/src/base/apps/findimageoverlaps/findimageoverlaps.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,13 @@ using namespace std;

namespace Isis {

void findimageoverlaps(UserInterface &ui, bool threadedCalculate, Pvl *log) {
void findimageoverlaps(UserInterface &ui, bool useThread, Pvl *log) {
FileList images(ui.GetFileName("FROMLIST"));

findimageoverlaps(images, ui, threadedCalculate, log);
findimageoverlaps(images, ui, useThread, log);
}

void findimageoverlaps(FileList &images, UserInterface &ui, bool threadedCalculate, Pvl *log) {
void findimageoverlaps(FileList &images, UserInterface &ui, bool useThread, Pvl *log) {
// list of sns/filenames sorted by serial number
SerialNumberList serialNumbers(true);

Expand Down Expand Up @@ -47,7 +47,7 @@ namespace Isis {
}

// Now we want the ImageOverlapSet to calculate our overlaps
ImageOverlapSet overlaps(true, threadedCalculate);
ImageOverlapSet overlaps(true, useThread);

// Use multi-threading to create the overlaps
overlaps.FindImageOverlaps(serialNumbers,
Expand Down
4 changes: 2 additions & 2 deletions isis/src/base/apps/findimageoverlaps/findimageoverlaps.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@
#include "UserInterface.h"

namespace Isis {
extern void findimageoverlaps(UserInterface &ui, bool threadedCalculate=true, Pvl *log=nullptr);
extern void findimageoverlaps(UserInterface &ui, bool useThread=true, Pvl *log=nullptr);

extern void findimageoverlaps(FileList &images, UserInterface &ui, bool threadedCalculate=true, Pvl *log=nullptr);
extern void findimageoverlaps(FileList &images, UserInterface &ui, bool useThread=true, Pvl *log=nullptr);
}

#endif
4 changes: 2 additions & 2 deletions isis/src/base/objs/ImageOverlapSet/ImageOverlapSet.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,12 @@ namespace Isis {
* addition to logging errors.
* @see automaticRegistration.doc
*/
ImageOverlapSet::ImageOverlapSet(bool continueOnError, bool threadedCalculate) {
ImageOverlapSet::ImageOverlapSet(bool continueOnError, bool useThread) {

p_continueAfterError = continueOnError;
p_writtenSoFar = 0;
p_calculatedSoFar = -1;
p_threadedCalculate = threadedCalculate;
p_threadedCalculate = useThread;
p_snlist = NULL;
}

Expand Down
2 changes: 1 addition & 1 deletion isis/src/base/objs/ImageOverlapSet/ImageOverlapSet.h
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ namespace Isis {
*/
class ImageOverlapSet : private QThread {
public:
ImageOverlapSet(bool continueOnError = false, bool threadedCalculate = true);
ImageOverlapSet(bool continueOnError = false, bool useThread = true);
virtual ~ImageOverlapSet();

void FindImageOverlaps(SerialNumberList &boundaries);
Expand Down

0 comments on commit d6e7c25

Please sign in to comment.