fix: update swagger issues and update generation flow #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes CrowdStrike#33 Adds block execute to definition. This should be finally fixed upstream as well. Fixes CrowdStrike#35 Updates endpoint response to be of type Object. This one is interesting because it seems like it should actually be returning a binary object but instead it returns either a CSV string or JSON object depending on the type of scheduled report that was chosen. When this is updated upstream we will treat this as a binary download such as downloading a sensor. This also fixes dealing with text/* returns such as csv. Now we just return it as a string instead of failing. The Makefile has been updated to make use of the transformation.jq file to ensure our swagger spec file has fixes needed while we wait for upstream support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33
Adds block execute to definition. This should be finally fixed upstream as well.
Fixes #35
Updates endpoint response to be of type Object. This one is interesting because it seems like it should actually be returning a binary object but instead it returns either a CSV string or JSON object depending on the type of scheduled report that was chosen. When this is updated upstream we will treat this as a binary download such as downloading a sensor.
This also fixes dealing with text/* returns such as csv. Now we just return it as a string instead of failing.
The Makefile has been updated to make use of the transformation.jq file to ensure our swagger spec file has fixes needed while we wait for upstream support.