Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ci fix #1334

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+2 −0
Open

fix: ci fix #1334

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a642979
Empty-Commit
Devanshusisodiya Feb 12, 2025
206a604
added package in setup
Devanshusisodiya Feb 12, 2025
9d5d206
added package in setup
Devanshusisodiya Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions python/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ def scan_for_package_data(
"jsonref>=1.1.0",
"inflection>=0.5.1",
"semver>=2.13.0",
"deeplake",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider pinning 'deeplake' with version constraints for consistency.

Suggested change
"deeplake",
"deeplake>=1.0.0,<2.0.0",

"azure",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The azure package dependency is too broad and may pull in unnecessary packages. Specify the exact Azure package(s) needed (e.g. azure-storage-blob, azure-core, etc).

📝 Committable Code Suggestion

‼️ Ensure you review the code suggestion before committing it to the branch. Make sure it replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
"azure",
"azure-storage-blob", "azure-core",

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider specifying a version constraint for 'azure' (e.g., 'azure>=x.y.z') to avoid potential compatibility issues.

# CLI dependencies
"click",
"rich>=13.7.1,<14",
Expand Down
Loading