Skip to content

Add subject into body for chains that require mail body #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gradecke
Copy link
Contributor

Proposed changes

check_mail_loop currently sends mails with an empty body and all info in the subject, this commit changes this so that the same string is also used as the body of the mail.

There are 2 reasons for this:

  1. e-mails with an empty body are sometimes viewed as suspicious and might get stuck in e-mail security solutions
  2. when the mail is passed through an sms gateway that can/will only forward the e-mail body as an sms text, usually this would break the mail loop, with this tiny change, the default check_mail_loop can still be used.
    (the same change in utils/mailbox.py in 2.3 is working in our customer production already.)

drawbacks:

  • a few bytes more? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants