Update ps_section.py

[fuf42]

General information

Simply ignore empty string_table here to prevent crash of ps check.

That occured through a broken agent not returning all needed ps-Informations but checking the existance of the dictionary won't hurt otherwise and makes the code more rubust

Bug reports

Crash report fcdadad2-0961-11f0-8161-ad7691f8c67a

Proposed changes

Expected behaviour: be more resilient against broken agent input. Do not crash. Ignore it.

[m3hransh]

@fuf42 After investigating, it seems that the check might be unnecessary. Could you provide more details on when exactly you encounter this crash? I highly doubt that the check for StringTable is needed, as the agent output should always be non-empty if the ps_lnx section is present (unless the agent crash between two echo).
For reference, here’s the relevant part from agents/check_mk_agent.linux:

section_ps() {
    if inpath ps; then
        # processes including username, without kernel processes
        echo '<<<ps_lnx>>>'
        echo "[time]"
        get_epoch
        echo "[processes]"
        CGROUP=""
        if [ -e /sys/fs/cgroup ]; then
            CGROUP="cgroup:512,"
        fi
        echo "[header] $(ps ax -ww -o "${CGROUP}"user:32,vsz,rss,cputime,etime,pid,command | tr -s ' ')"
    fi
}

[fuf42]

Hi,

it's an android device with a broken agent which I cannot fix. The ps-section is simply empty.

<<<mounts>>>
rootfs / rootfs ro,seclabel 0 0
....
tmpfs /storage/self tmpfs rw,seclabel,relatime,size=906132k,mode=755,gid=1000 0 0
<<<ps>>>
<<<mem>>>
....

yes, this is not really a checkmk-core-Problem, more a fundamental question, but as I wrote I think it might be better to deal with possible wrong inputs than to crash the check

Christian